feat: log malformed data during upsert ES docs #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7407053139
💛 - Coveralls |
haveiss
reviewed
Jan 4, 2024
haveiss
reviewed
Jan 4, 2024
batrov
force-pushed
the
log-malformed-upsert
branch
from
7221f01 to
6bab8f3
Compare
batrov
force-pushed
the
log-malformed-upsert
branch
from
6bab8f3 to
5342b6e
Compare
haveiss
approved these changes
Jan 4, 2024
sumslim
reviewed
Jan 4, 2024
| @@ -61,6 +65,10 @@ func (m *InSituWorker) EnqueueSyncAssetJob(ctx context.Context, service string) | |||
|
|
|||
| for _, ast := range assets { | |||
| if err := m.discoveryRepo.Upsert(ctx, ast); err != nil { | |||
| if strings.Contains(err.Error(), "illegal_argument_exception") { | |||
| m.logger.Error(err.Error()) | |||
| continue | |||
There was a problem hiding this comment.
@batrov just trying to understand here, if we have invalid format/argument for the field, we want to ignore it and keep processing remaining assets, but if we get any other error while upserting, we will return the error, without processing remaining assets?
There was a problem hiding this comment.
yes that is expected, that way the backed up index won't get deleted and we can analyze other error before retrying the sync job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore_malformedfor object data type [ref]