Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional attributes when getting graph #76

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Conversation

irainia
Copy link

@irainia irainia commented Jul 25, 2024

This PR is to allow for optional attributes to be specified when getting graph

@irainia irainia self-assigned this Jul 25, 2024
@coveralls
Copy link

coveralls commented Jul 25, 2024

Pull Request Test Coverage Report for Build 10092692634

Details

  • 10 of 12 (83.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 85.134%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/server/v1beta1/lineage.go 5 7 71.43%
Totals Coverage Status
Change from base Build 9592932614: -0.006%
Covered Lines: 6345
Relevant Lines: 7453

💛 - Coveralls

@@ -807,6 +807,7 @@ func TestService_GetLineage(t *testing.T) {
type testCase struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add another test case with withAttribute false

@haveiss haveiss merged commit 8318c34 into main Jul 25, 2024
3 checks passed
@haveiss haveiss deleted the feat-optional-attributes branch July 25, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants