feat(warden): added team-name & product-group-name

goto · Oct 16, 2023 · e885442 · e885442
1 parent 97f59b2
commit e885442
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 8 deletions.
diff --git a/internal/server/v1/iam/handler_test.go b/internal/server/v1/iam/handler_test.go
@@ -128,17 +128,21 @@ func TestHandlerUpdateGroup(t *testing.T) {
 		dexGroupMetadataResponse := `{
 			"privacy": "public",
 			"product-group-id": "2079834a-05c4-420d-bfc8-44b934adea9f",
-			"team-id": "b5aea046-dab3-4dac-b1ea-e1eef423226b"
+			"team-id": "b5aea046-dab3-4dac-b1ea-e1eef423226b",
+			"team-name": "data_fabric",
+			"product-group-name": "data_engineering"
 		}`
 		groupID := "e38527ee-a8cd-40f9-98a7-1f0bbd20909f"
 		metaData, _ := structpb.NewStruct(map[string]any{
 			"privacy": "public",
 		})
 
 		updatedMetaData, _ := structpb.NewStruct(map[string]any{
-			"privacy":          "public",
-			"team-id":          "b5aea046-dab3-4dac-b1ea-e1eef423226b",
-			"product-group-id": "2079834a-05c4-420d-bfc8-44b934adea9f",
+			"privacy":            "public",
+			"team-id":            "b5aea046-dab3-4dac-b1ea-e1eef423226b",
+			"team-name":          "data_fabric",
+			"product-group-id":   "2079834a-05c4-420d-bfc8-44b934adea9f",
+			"product-group-name": "data_engineering",
 		})
 
 		wardenClient := mocks.NewWardenClient(t)
@@ -265,7 +269,7 @@ func TestHandlerUpdateGroup(t *testing.T) {
 		assert.JSONEq(t, dexGroupMetadataResponse, resp.Body.String())
 	})
 
-	t.Run("ShielUpdateGroupFailure", func(t *testing.T) {
+	t.Run("ShieldUpdateGroupFailure", func(t *testing.T) {
 		// response returned by shield client
 		dexGroupMetadataResponse := `{"code":"internal_error", "message":"Some unexpected error occurred", "op":"", "status":500}`
 		groupID := "e38527ee-a8cd-40f9-98a7-1f0bbd20909f"
@@ -274,9 +278,11 @@ func TestHandlerUpdateGroup(t *testing.T) {
 		})
 
 		updatedMetaData, _ := structpb.NewStruct(map[string]any{
-			"privacy":          "public",
-			"team-id":          "b5aea046-dab3-4dac-b1ea-e1eef423226b",
-			"product-group-id": "2079834a-05c4-420d-bfc8-44b934adea9f",
+			"privacy":            "public",
+			"team-id":            "b5aea046-dab3-4dac-b1ea-e1eef423226b",
+			"team-name":          "data_fabric",
+			"product-group-id":   "2079834a-05c4-420d-bfc8-44b934adea9f",
+			"product-group-name": "data_engineering",
 		})
 
 		wardenClient := mocks.NewWardenClient(t)

diff --git a/internal/server/v1/iam/service.go b/internal/server/v1/iam/service.go
@@ -63,7 +63,9 @@ func (svc *Service) UpdateGroupMetadata(ctx context.Context, groupID, wardenTeam
 	}
 
 	metaData["team-id"] = team.Identifier
+	metaData["team-name"] = team.Name
 	metaData["product-group-id"] = team.ProductGroupID
+	metaData["product-group-name"] = team.ProductGroupName
 
 	updatedMetaData, err := structpb.NewStruct(metaData)
 	if err != nil {