Skip to content

Commit

Permalink
Firehose JRE upgrade to jre8u412 (#42)
Browse files Browse the repository at this point in the history
Context:
The current image which is being used in the firehose is https://hub.docker.com/layers/library/openjdk/8-jre/images/sha256-a6a74c7b774e00fd2ec5664e257d344f1b7e69e2a618b1c0678f69719863c5ad which is using 8u342 jre.

Problem Statement:
As mentioned in the Kubernetes docs, if the container deployment has to be aware of cgroup v2, we should use jre8u372 or later.
https://kubernetes.io/docs/concepts/architecture/cgroups/#migrating-cgroupv2
https://bugs.openjdk.org/browse/JDK-8230305

Analysis:
OpenJDK HomePage https://hub.docker.com/_/openjdk mentions that these images are for Pre-release / non-production builds.
This image is officially deprecated and all users are recommended to find and use suitable replacements ASAP.
More Details here: docker-library/openjdk#505
Even adoptOpenJDK images are deprecated https://hub.docker.com/_/adoptopenjdk and they recommend to use below trusted community jre/jdk builds

eclipse-temurin: is one of the recommended jre Trusted Community - eclipse-temurin:8u412-b08-jre
This is also used in flink/dagger image
https://hub.docker.com/layers/library/eclipse-temurin/8u412-b08-jre/images/sha256-4862d0a70086408ddb5267a5c1d83a8d4d2656095d71ab4318b178f38fe1321e?context=explore

Amazon Corretto - some users have complained about the memory management issues
https://www.g2.com/products/amazon-corretto/reviews#survey-response-9386019

Solution:
Since we are using the Eclipse Temurin JDK release in Dagger and the Flink community is also using it, we have decided to do the same.

Co-authored-by: rajuGT <[email protected]>
  • Loading branch information
rajuGT and rajuGT authored Jun 20, 2024
1 parent ff9e2a9 commit db3a31c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ RUN curl -L http://search.maven.org/remotecontent?filepath=org/jolokia/jolokia-j
COPY ./ ./
RUN ./gradlew build

FROM openjdk:8-jre
FROM eclipse-temurin:8u412-b08-jre
RUN apt-get update && apt-get upgrade -y curl
COPY --from=GRADLE_BUILD ./build/libs/ /opt/firehose/bin
COPY --from=GRADLE_BUILD ./jolokia-jvm-agent.jar /opt/firehose
Expand Down

0 comments on commit db3a31c

Please sign in to comment.