feat: support ability to use json message for http sink #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsushmith
changed the title
|
@bsushmith we have included support for JSON message type in httpV2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, http sink supports only having proto messages in kafka topic. These changes also support having a topic with only json messages when using a http sink.
Reasoning behind the changes in the PR:
Firehose currently tightly couples the source message format and the output sink format. As part of our analysis to add support for the use case of being able to read json message from kafka and send to http sink, we realized that adding the
InputSchemTypetoMessageobject would be a simpler way to solve this, without having to change the existing code too much and at the same time without muddling it up.