Firehose 0.10.3 which has cgroup v2 changes #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 19, 2024 18:22
Context: The current image which is being used in the firehose is https://hub.docker.com/layers/library/openjdk/8-jre/images/sha256-a6a74c7b774e00fd2ec5664e257d344f1b7e69e2a618b1c0678f69719863c5ad which is using 8u342 jre. Problem Statement: As mentioned in the Kubernetes docs, if the container deployment has to be aware of cgroup v2, we should use jre8u372 or later. https://kubernetes.io/docs/concepts/architecture/cgroups/#migrating-cgroupv2 https://bugs.openjdk.org/browse/JDK-8230305 Analysis: OpenJDK HomePage https://hub.docker.com/_/openjdk mentions that these images are for Pre-release / non-production builds. This image is officially deprecated and all users are recommended to find and use suitable replacements ASAP. More Details here: docker-library/openjdk#505 Even adoptOpenJDK images are deprecated https://hub.docker.com/_/adoptopenjdk and they recommend to use below trusted community jre/jdk builds eclipse-temurin: is one of the recommended jre Trusted Community - eclipse-temurin:8u412-b08-jre This is also used in flink/dagger image https://hub.docker.com/layers/library/eclipse-temurin/8u412-b08-jre/images/sha256-4862d0a70086408ddb5267a5c1d83a8d4d2656095d71ab4318b178f38fe1321e?context=explore Amazon Corretto - some users have complained about the memory management issues https://www.g2.com/products/amazon-corretto/reviews#survey-response-9386019 Solution: Since we are using the Eclipse Temurin JDK release in Dagger and the Flink community is also using it, we have decided to do the same.
Resolved merge conflicts Conflicts: build.gradle Added .DS_Store in gitIgnore file
sbchaos
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.