Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Retryable Configuration for GRPC Sink (using CEL) #44

Merged
merged 39 commits into from
Jul 24, 2024
Merged

feat: Add Retryable Configuration for GRPC Sink (using CEL) #44

merged 39 commits into from
Jul 24, 2024

Conversation

ekawinataa
Copy link

@ekawinataa ekawinataa commented Jul 4, 2024 •
edited
Loading

Purpose:
Add new config to enable response based retry in gRPC Sink Config. Request by EGLC users, this feature is provided in EGLC.

Example Parameter:
SINK_GRPC_RESPONSE_RETRY_CEL_EXPRESSION ="GenericResponse.success == false && GenericResponse.errors.exists(e, e.code == "400")"

Reason for the PR:
EGLC users who want to migrate expect this feature to be supported in Firehose

Other sources :
CEL Expression: https://cel.dev/
cel-java: https://github.com/google/cel-java

@ekawinataa ekawinataa changed the title [WIP] [feat] Add CEL evaluator and add it to grpc sink [WIP] [feat] Add CEL Retry evaluator and add it to grpc sink Jul 4, 2024
@ekawinataa ekawinataa changed the title [WIP] [feat] Add CEL Retry evaluator and add it to grpc sink feat:Add CEL Retry evaluator and add it to grpc sink Jul 8, 2024
@ekawinataa ekawinataa changed the title feat:Add CEL Retry evaluator and add it to grpc sink feat: Add CEL Retry evaluator and add it to grpc sink Jul 8, 2024
@ekawinataa
Copy link
Author

Purpose:
Add new config to enable response based retry in gRPC Sink Config

Example Parameter:
SINK_GRPC_RESPONSE_RETRY_CEL_EXPRESSION ="GenericResponse.success == false && GenericResponse.errors.exists(e, e.code == "400")"

Reason for the PR:
EGLC users who want to migrate expect this feature to be supported in Firehose

Notes :

@ekawinataa ekawinataa changed the title feat: Add CEL Retry evaluator and add it to grpc sink feat: Add Retryable Configuration for GRPC Sink (using CEL) Jul 9, 2024
@rajuGT rajuGT merged commit ba3220e into main Jul 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajuGT rajuGT rajuGT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekawinataa @rajuGT