feat: oss Provider #193
Merged
feat: oss Provider #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushi0014
force-pushed
the
oss-provider
branch
from
521badd to
676a585
Compare
idilhaq
reviewed
Dec 9, 2024
plugins/providers/oss/config.go
Outdated
| AccountTypeRAMUser = "ram_user" | ||
| AccountTypeRAMRole = "ram_role" | ||
| resourceTypeBucket = "bucket" | ||
| parameterRAMRoleKey = "ram_role" |
There was a problem hiding this comment.
since the value is similar, can't we just use AccountTypeRAMRole ?
There was a problem hiding this comment.
this field is not being used, I've removed it for now. thanks for pointing out!
abhishekv24
reviewed
Dec 10, 2024
| func findStatementsWithMatchingActions(bucketPolicy Policy, resourceAccountID string, g domain.Grant) ([]PolicyStatement, []PolicyStatement) { | ||
| var statements []PolicyStatement | ||
| var matchingStatements []PolicyStatement | ||
| for _, statement := range bucketPolicy.Statement { |
There was a problem hiding this comment.
Let's try to merge this loop with the one here to reduce the number of iterations. I think we can do the same for revoke flow.
| if err != nil { | ||
| var ossErr oss.ServiceError | ||
| if errors.As(err, &ossErr) && ossErr.StatusCode == http.StatusNotFound { | ||
| return fmt.Errorf("access not found for role: %s", g.Role) |
There was a problem hiding this comment.
this is the case where bucket policy is not found right? let's update the error message accordingly.
ayushi0014
force-pushed
the
oss-provider
branch
from
7401a2d to
6454e9b
Compare
…erent clients(odps/rest/oss)
added 5 commits
December 13, 2024 00:28
ayushi0014
force-pushed
the
oss-provider
branch
from
049e50f to
8e443b9
Compare
…erent clients(odps/rest/oss)
ayushi0014
force-pushed
the
maxcompute-provider
branch
from
8396a0f to
d094e7f
Compare
ayushi0014
force-pushed
the
oss-provider
branch
from
8e443b9 to
038eeff
Compare
rahmatrhd
approved these changes
Dec 16, 2024
rahmatrhd
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.