Replay cancel scheduled cleared reruns #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Mryashbhardwaj
commented
Oct 18, 2024
•
Mryashbhardwaj
commented
- replay should not cancel non replay managed runs
- also cancel cleared runs(one's that were originally scheduled but cleared by replay)
…d runs(one's that were originally scheduled but cleared by replay)
…ncel_scheduled_reruns
arinda-arif
reviewed
Oct 21, 2024
| @@ -235,15 +234,17 @@ func (r *ReplayService) cancelReplayRuns(ctx context.Context, replayWithRun *sch | |||
| return err | |||
| } | |||
|
|
|||
| syncedRunStatus, err := r.executor.SyncStatus(ctx, replayWithRun, jobCron) | |||
| jobRunsRunsWithDetails, err := r.executor.FetchRunsWithDetails(ctx, replay, jobCron) | |||
| logicalTime := run.GetLogicalTime(jobCron) | ||
| runState := scheduler.JobRunStatus{ | ||
| ScheduledAt: run.ScheduledAt, | ||
| State: run.State, |
There was a problem hiding this comment.
Let's verify whether the canceled runs will still have the origin state or the updated ones. I believe we are expecting canceled status?
There was a problem hiding this comment.
yeah you are right this should be scheduler.StateCanceled
sravankorumilli
approved these changes
Oct 21, 2024
deryrahman
pushed a commit
that referenced
this pull request
Oct 23, 2024
* fix: replay do not cancel non replay managed runs, also cancel cleared runs(one's that were originally scheduled but cleared by replay) * fix: typos and add logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.