Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table deprecation support #307

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Mryashbhardwaj
Copy link
Member

Proton PR: goto/proton#140

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it accidently commited ?

@@ -320,6 +320,7 @@ spec:
- mode: nullable
name: name
type: string
deprecation: null

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add unit test for deprecation is exists ?

if r.Deprecation != nil && len(r.Deprecation.Date) > 0 {
deprecationDate, err := time.Parse(time.DateOnly, r.Deprecation.Date)
if err != nil {
return nil, fmt.Errorf("error parsing deprivation Date, for resource: %s, expected_format: [YYYY-MM-DD], got: [%s], err: %w", r.Name, r.Deprecation.Date, err)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was some typo in the message

Suggested change
return nil, fmt.Errorf("error parsing deprivation Date, for resource: %s, expected_format: [YYYY-MM-DD], got: [%s], err: %w", r.Name, r.Deprecation.Date, err)
return nil, fmt.Errorf("error parsing deprecation Date, for resource: %s, expected_format: [YYYY-MM-DD], got: [%s], err: %w", r.Name, r.Deprecation.Date, err)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants