Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(optimus): add result level on job validate #141

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(optimus): add result level on job validate #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e7cf71
fix : add deprication info in resource proto
Mryashbhardwaj Dec 6, 2024
96b1ee6
feat(optimus): add result level on job validate
Dec 10, 2024
f00fdef
feat(optimus): change level from status proto
Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gotocompany/optimus/core/v1beta1/job_spec.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,7 @@ message ValidateResponse {
string name = 1;
repeated string messages = 2;
bool success = 3;
optional Level level = 4;
}

message ResultList {
Expand Down
10 changes: 9 additions & 1 deletion gotocompany/optimus/core/v1beta1/resource.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ package gotocompany.optimus.core.v1beta1;

import "google/api/annotations.proto";
import "google/protobuf/struct.proto";
import "google/protobuf/timestamp.proto";
import "gotocompany/optimus/core/v1beta1/status.proto";
import "protoc-gen-openapiv2/options/annotations.proto";

Expand Down Expand Up @@ -175,6 +176,12 @@ message ResourceStatus {
string message = 3;
}

message Deprecation {
string reason = 1;
google.protobuf.Timestamp date = 2;
string replacement_table = 3;
}

// ResourceSpecification are datastore specification representation of a resource
message ResourceSpecification {
reserved 3; // depricated "datastore"
Expand All @@ -186,8 +193,9 @@ message ResourceSpecification {
google.protobuf.Struct spec = 5;
map<string, string> assets = 6;
map<string, string> labels = 7;
}

Deprecation deprecation = 8;
}

message ChangeResourceNamespaceRequest {
string project_name = 1;
Expand Down
Loading