test: fix wrong response

goto · Jul 10, 2024 · 8d51441 · 8d51441
1 parent 1c30d4b
commit 8d51441
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/internal/api/v1beta1/servicedata.go b/internal/api/v1beta1/servicedata.go
@@ -13,6 +13,7 @@ import (
 	"github.com/goto/shield/core/servicedata"
 	"github.com/goto/shield/core/user"
 	"github.com/goto/shield/internal/schema"
+	errPkg "github.com/goto/shield/pkg/errors"
 	shieldv1beta1 "github.com/goto/shield/proto/v1beta1"
 	grpczap "github.com/grpc-ecosystem/go-grpc-middleware/logging/zap/ctxzap"
 	"golang.org/x/exp/maps"
@@ -128,6 +129,8 @@ func (h Handler) UpsertUserServiceData(ctx context.Context, request *shieldv1bet
 			switch {
 			case errors.Is(err, user.ErrInvalidEmail), errors.Is(err, user.ErrMissingEmail):
 				return nil, grpcUnauthenticated
+			case errors.Is(err, errPkg.ErrForbidden):
+				return nil, grpcPermissionDenied
 			case errors.Is(err, project.ErrNotExist), errors.Is(err, servicedata.ErrInvalidDetail),
 				errors.Is(err, relation.ErrInvalidDetail), errors.Is(err, servicedata.ErrNotExist):
 				return nil, grpcBadBodyError

diff --git a/test/e2e_test/regression/api_test.go b/test/e2e_test/regression/api_test.go
@@ -599,7 +599,7 @@ func (s *EndToEndAPIRegressionTestSuite) TestServiceDataAPI() {
 				},
 			},
 		})
-		s.Assert().Equal(codes.Unauthenticated, status.Convert(err).Code())
+		s.Assert().Equal(codes.PermissionDenied, status.Convert(err).Code())
 	})
 
 	s.Run("9. org admin update a group service data with invalid group id should return invalid argument error", func() {
-Original file line number
+Diff line change
@@ Expand Up @@
     				},
     			},
     		})
-    		s.Assert().Equal(codes.Unauthenticated, status.Convert(err).Code())
+    		s.Assert().Equal(codes.PermissionDenied, status.Convert(err).Code())
     	})
     	s.Run("9. org admin update a group service data with invalid group id should return invalid argument error", func() {
@@ Expand Down @@