Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: authz middleware to accept both slug and uuid for system ns #34

Merged
merged 7 commits into from
Mar 13, 2024

Conversation

ishanarya0
Copy link
Member

authz middleware to accept both slug and uuid for system ns

@mabdh
Copy link
Member

mabdh commented Mar 13, 2024

@ishanarya0 can you please add tests on this changes too?

@ishanarya0
Copy link
Member Author

@ishanarya0 can you please add tests on this changes too?
yes mas, this is WIP

@ishanarya0 ishanarya0 changed the title feat: authz middleware to accept both slug and uuid for system ns [WIP] feat: authz middleware to accept both slug and uuid for system ns Mar 13, 2024
@mabdh
Copy link
Member

mabdh commented Mar 13, 2024

@ishanarya0 you could convert this as draft first

@ishanarya0
Copy link
Member Author

@ishanarya0 you could convert this as draft first

but i want to run tests and lint actions. I am not sure these run on draft PRs.
I'll request for a review once I am done.

@ishanarya0 ishanarya0 changed the title [WIP] feat: authz middleware to accept both slug and uuid for system ns feat: authz middleware to accept both slug and uuid for system ns Mar 13, 2024
@ishanarya0 ishanarya0 requested review from mabdh, manishdangi98 and AkarshSatija and removed request for AkarshSatija, mabdh and manishdangi98 March 13, 2024 07:50
@ishanarya0 ishanarya0 changed the title feat: authz middleware to accept both slug and uuid for system ns [WIP] feat: authz middleware to accept both slug and uuid for system ns Mar 13, 2024
@ishanarya0 ishanarya0 requested a review from mabdh March 13, 2024 08:11
@ishanarya0 ishanarya0 changed the title [WIP] feat: authz middleware to accept both slug and uuid for system ns feat: authz middleware to accept both slug and uuid for system ns Mar 13, 2024
@ishanarya0 ishanarya0 merged commit 713e2e8 into main Mar 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants