Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add stdout repository activity #40

Merged
merged 1 commit into from
Apr 22, 2024
Merged

feat: add stdout repository activity #40

merged 1 commit into from
Apr 22, 2024

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented Apr 20, 2024

  • Add option to use logger instead of sinking to DB for activity logs

@mabdh mabdh force-pushed the activity-logger-stdout branch 7 times, most recently from 06d5781 to d4e0e0e Compare April 22, 2024 06:09
ishanarya0
ishanarya0 requested changes Apr 22, 2024
View reviewed changes
pkg/logger/logger.go Outdated Show resolved Hide resolved
@mabdh mabdh requested a review from ishanarya0 April 22, 2024 06:11
ishanarya0
ishanarya0 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@ishanarya0 ishanarya0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
let's also update the docs adding details of this configuration to chose from db and stdout

@mabdh
Copy link
Member Author

mabdh commented Apr 22, 2024

LGTM let's also update the docs adding details of this configuration to chose from db and stdout

sure things, will update the docs

@mabdh mabdh force-pushed the activity-logger-stdout branch from d4e0e0e to bd85fbc Compare April 22, 2024 08:06
@mabdh mabdh merged commit 535a1b3 into main Apr 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishanarya0 ishanarya0 ishanarya0 approved these changes

@FemiNoviaLina FemiNoviaLina Awaiting requested review from FemiNoviaLina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mabdh @ishanarya0