chore: bump up go version to 1.21

.github/workflows/build_dev.yml

@@ -13,7 +13,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: '1.18.3'
+          go-version: '1.21'
       - name: Login to DockerHub
         uses: docker/login-action@v1
         with:

.github/workflows/lint.yml

@@ -13,12 +13,12 @@ jobs:
     steps:
       - uses: actions/setup-go@v2
         with:
-          go-version: '1.18'
+          go-version: '1.21'
       - uses: actions/checkout@v2
         with:
           fetch-depth: 0
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v4
         with:
           skip-go-installation: true
-          version: v1.50.1
+          version: v1.54

.github/workflows/release.yml

@@ -17,7 +17,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: '1.18.3'
+          go-version: '1.21'
       - name: Login to DockerHub
         uses: docker/login-action@v1
         with:

.github/workflows/test.yml

@@ -29,7 +29,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: '1.18'
+          go-version: '1.21'
       - name: install dependencies
         run: go mod tidy
       - name: test binaries
@@ -74,7 +74,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: '1.18'
+          go-version: '1.21'
       - name: install dependencies
         run: go mod tidy
       - name: install spicedb binary

Dockerfile.dev

@@ -1,4 +1,4 @@
-FROM golang:1.18-alpine3.15 as builder
+FROM golang:1.21-alpine3.19 as builder
 
 RUN apk add make
 
@@ -11,7 +11,7 @@ COPY . .
 
 RUN make build
 
-FROM alpine:3.16
+FROM alpine:3.19
 COPY --from=builder /go/src/app/shield /usr/bin/
 RUN apk update
 RUN apk add ca-certificates

docs/docs/installation.md

@@ -51,7 +51,7 @@ $ docker run -p 8080:8080 \
 
 Shield requires the following dependencies:
 
-- Golang (version 1.18 or above)
+- Golang (version 1.21 or above)
 - Git
 
 ### Build

go.mod

@@ -1,6 +1,6 @@
 module github.com/goto/shield
 
-go 1.18
+go 1.21
 
 require (
 	contrib.go.opencensus.io/exporter/prometheus v0.4.2

internal/api/v1beta1/action_test.go

@@ -146,7 +146,7 @@ func TestCreateAction(t *testing.T) {
 		{
 			title: "should return internal error if action service return some error",
 			setup: func(as *mocks.ActionService) {
-				as.EXPECT().Create(mock.AnythingOfType("*context.emptyCtx"), action.Action{
+				as.EXPECT().Create(mock.AnythingOfType("context.todoCtx"), action.Action{
 					ID:          testActionMap[testActionID].ID,
 					Name:        testActionMap[testActionID].Name,
 					NamespaceID: testActionMap[testActionID].NamespaceID,
@@ -164,7 +164,7 @@ func TestCreateAction(t *testing.T) {
 		{
 			title: "should return bad request error if namespace id is wrong",
 			setup: func(as *mocks.ActionService) {
-				as.EXPECT().Create(mock.AnythingOfType("*context.emptyCtx"), action.Action{
+				as.EXPECT().Create(mock.AnythingOfType("context.todoCtx"), action.Action{
 					ID:          testActionMap[testActionID].ID,
 					Name:        testActionMap[testActionID].Name,
 					NamespaceID: testActionMap[testActionID].NamespaceID,
@@ -182,7 +182,7 @@ func TestCreateAction(t *testing.T) {
 		{
 			title: "should return bad request error if if id is empty",
 			setup: func(as *mocks.ActionService) {
-				as.EXPECT().Create(mock.AnythingOfType("*context.emptyCtx"), action.Action{
+				as.EXPECT().Create(mock.AnythingOfType("context.todoCtx"), action.Action{
 					Name:        testActionMap[testActionID].Name,
 					NamespaceID: testActionMap[testActionID].NamespaceID,
 				}).Return(action.Action{}, action.ErrInvalidID)
@@ -198,7 +198,7 @@ func TestCreateAction(t *testing.T) {
 		{
 			title: "should return bad request error if if name is empty",
 			setup: func(as *mocks.ActionService) {
-				as.EXPECT().Create(mock.AnythingOfType("*context.emptyCtx"), action.Action{
+				as.EXPECT().Create(mock.AnythingOfType("context.todoCtx"), action.Action{
 					ID:          testActionMap[testActionID].ID,
 					NamespaceID: testActionMap[testActionID].NamespaceID,
 				}).Return(action.Action{}, action.ErrInvalidDetail)
@@ -214,7 +214,7 @@ func TestCreateAction(t *testing.T) {
 		{
 			title: "should return success if action service return nil error",
 			setup: func(as *mocks.ActionService) {
-				as.EXPECT().Create(mock.AnythingOfType("*context.emptyCtx"), action.Action{
+				as.EXPECT().Create(mock.AnythingOfType("context.todoCtx"), action.Action{
 					ID:          testActionMap[testActionID].ID,
 					Name:        testActionMap[testActionID].Name,
 					NamespaceID: testActionMap[testActionID].NamespaceID,
@@ -246,7 +246,7 @@ func TestCreateAction(t *testing.T) {
 				tt.setup(mockActionSrv)
 			}
 			mockDep := Handler{actionService: mockActionSrv}
-			resp, err := mockDep.CreateAction(context.Background(), tt.req)
+			resp, err := mockDep.CreateAction(context.TODO(), tt.req)
 			assert.EqualValues(t, tt.want, resp)
 			assert.EqualValues(t, tt.err, err)
 		})
@@ -264,7 +264,7 @@ func TestHandler_GetAction(t *testing.T) {
 		{
 			name: "should return internal error if action service return some error",
 			setup: func(as *mocks.ActionService) {
-				as.EXPECT().Get(mock.AnythingOfType("*context.emptyCtx"), testActionID).Return(action.Action{}, errors.New("some error"))
+				as.EXPECT().Get(mock.AnythingOfType("context.todoCtx"), testActionID).Return(action.Action{}, errors.New("some error"))
 			},
 			request: &shieldv1beta1.GetActionRequest{
 				Id: testActionID,
@@ -275,7 +275,7 @@ func TestHandler_GetAction(t *testing.T) {
 		{
 			name: "should return not found error if action id not exist",
 			setup: func(as *mocks.ActionService) {
-				as.EXPECT().Get(mock.AnythingOfType("*context.emptyCtx"), testActionID).Return(action.Action{}, action.ErrNotExist)
+				as.EXPECT().Get(mock.AnythingOfType("context.todoCtx"), testActionID).Return(action.Action{}, action.ErrNotExist)
 			},
 			request: &shieldv1beta1.GetActionRequest{
 				Id: testActionID,
@@ -286,7 +286,7 @@ func TestHandler_GetAction(t *testing.T) {
 		{
 			name: "should return not found error if action id is empty",
 			setup: func(as *mocks.ActionService) {
-				as.EXPECT().Get(mock.AnythingOfType("*context.emptyCtx"), "").Return(action.Action{}, action.ErrInvalidID)
+				as.EXPECT().Get(mock.AnythingOfType("context.todoCtx"), "").Return(action.Action{}, action.ErrInvalidID)
 			},
 			request: &shieldv1beta1.GetActionRequest{},
 			want:    nil,
@@ -295,7 +295,7 @@ func TestHandler_GetAction(t *testing.T) {
 		{
 			name: "should return success if action service return nil error",
 			setup: func(as *mocks.ActionService) {
-				as.EXPECT().Get(mock.AnythingOfType("*context.emptyCtx"), testActionID).Return(testActionMap[testActionID], nil)
+				as.EXPECT().Get(mock.AnythingOfType("context.todoCtx"), testActionID).Return(testActionMap[testActionID], nil)
 			},
 			request: &shieldv1beta1.GetActionRequest{
 				Id: testActionID,
@@ -318,7 +318,7 @@ func TestHandler_GetAction(t *testing.T) {
 				tt.setup(mockActionSrv)
 			}
 			mockDep := Handler{actionService: mockActionSrv}
-			resp, err := mockDep.GetAction(context.Background(), tt.request)
+			resp, err := mockDep.GetAction(context.TODO(), tt.request)
 			assert.EqualValues(t, tt.want, resp)
 			assert.EqualValues(t, tt.wantErr, err)
 		})
@@ -336,7 +336,7 @@ func TestHandler_UpdateAction(t *testing.T) {
 		{
 			name: "should return internal error if action service return some error",
 			setup: func(as *mocks.ActionService) {
-				as.EXPECT().Update(mock.AnythingOfType("*context.emptyCtx"), testActionID, action.Action{
+				as.EXPECT().Update(mock.AnythingOfType("context.todoCtx"), testActionID, action.Action{
 					ID:          testActionID,
 					Name:        testActionMap[testActionID].Name,
 					NamespaceID: testActionMap[testActionID].NamespaceID,
@@ -355,7 +355,7 @@ func TestHandler_UpdateAction(t *testing.T) {
 		{
 			name: "should return not found error if action id not exist",
 			setup: func(as *mocks.ActionService) {
-				as.EXPECT().Update(mock.AnythingOfType("*context.emptyCtx"), testActionID, action.Action{
+				as.EXPECT().Update(mock.AnythingOfType("context.todoCtx"), testActionID, action.Action{
 					ID:          testActionID,
 					Name:        testActionMap[testActionID].Name,
 					NamespaceID: testActionMap[testActionID].NamespaceID}).Return(action.Action{}, action.ErrNotExist)
@@ -374,7 +374,7 @@ func TestHandler_UpdateAction(t *testing.T) {
 		{
 			name: "should return not found error if action id is empty",
 			setup: func(as *mocks.ActionService) {
-				as.EXPECT().Update(mock.AnythingOfType("*context.emptyCtx"), "", action.Action{
+				as.EXPECT().Update(mock.AnythingOfType("context.todoCtx"), "", action.Action{
 					Name:        testActionMap[testActionID].Name,
 					NamespaceID: testActionMap[testActionID].NamespaceID}).Return(action.Action{}, action.ErrInvalidID)
 			},
@@ -391,7 +391,7 @@ func TestHandler_UpdateAction(t *testing.T) {
 		{
 			name: "should return bad request error if namespace id not exist",
 			setup: func(as *mocks.ActionService) {
-				as.EXPECT().Update(mock.AnythingOfType("*context.emptyCtx"), testActionMap[testActionID].ID, action.Action{
+				as.EXPECT().Update(mock.AnythingOfType("context.todoCtx"), testActionMap[testActionID].ID, action.Action{
 					ID:          testActionID,
 					Name:        testActionMap[testActionID].Name,
 					NamespaceID: testActionMap[testActionID].NamespaceID}).Return(action.Action{}, namespace.ErrNotExist)
@@ -410,7 +410,7 @@ func TestHandler_UpdateAction(t *testing.T) {
 		{
 			name: "should return bad request error if name is empty",
 			setup: func(as *mocks.ActionService) {
-				as.EXPECT().Update(mock.AnythingOfType("*context.emptyCtx"), testActionMap[testActionID].ID, action.Action{
+				as.EXPECT().Update(mock.AnythingOfType("context.todoCtx"), testActionMap[testActionID].ID, action.Action{
 					ID:          testActionID,
 					NamespaceID: testActionMap[testActionID].NamespaceID}).Return(action.Action{}, action.ErrInvalidDetail)
 			},
@@ -427,7 +427,7 @@ func TestHandler_UpdateAction(t *testing.T) {
 		{
 			name: "should return success if action service return nil error",
 			setup: func(as *mocks.ActionService) {
-				as.EXPECT().Update(mock.AnythingOfType("*context.emptyCtx"), testActionMap[testActionID].ID, action.Action{
+				as.EXPECT().Update(mock.AnythingOfType("context.todoCtx"), testActionMap[testActionID].ID, action.Action{
 					ID:          testActionID,
 					Name:        testActionMap[testActionID].Name,
 					NamespaceID: testActionMap[testActionID].NamespaceID,
@@ -459,7 +459,7 @@ func TestHandler_UpdateAction(t *testing.T) {
 				tt.setup(mockActionSrv)
 			}
 			mockDep := Handler{actionService: mockActionSrv}
-			resp, err := mockDep.UpdateAction(context.Background(), tt.request)
+			resp, err := mockDep.UpdateAction(context.TODO(), tt.request)
 			assert.EqualValues(t, tt.want, resp)
 			assert.EqualValues(t, tt.wantErr, err)
 		})