forked from raystack/frontier
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add create service data #47
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FemiNoviaLina
commented
May 15, 2024
- Create service data key model
- Create Service Data Key Creation API
mabdh
reviewed
May 15, 2024
mabdh
reviewed
May 15, 2024
mabdh
reviewed
May 15, 2024
FemiNoviaLina
force-pushed
the
service-data-key-creation
branch
from
May 16, 2024 04:23
ed9cb8c
to
9471f16
Compare
mabdh
reviewed
May 16, 2024
mabdh
reviewed
May 17, 2024
@FemiNoviaLina some lint errors there, can you please run |
FemiNoviaLina
force-pushed
the
service-data-key-creation
branch
2 times, most recently
from
May 17, 2024 09:54
3099563
to
004ad16
Compare
FemiNoviaLina
force-pushed
the
service-data-key-creation
branch
from
May 17, 2024 10:08
004ad16
to
95c3303
Compare
mabdh
approved these changes
May 17, 2024
mabdh
added a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.