Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add create service data #47

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

FemiNoviaLina
Copy link

  • Create service data key model
  • Create Service Data Key Creation API

core/servicedata/errors.go Outdated Show resolved Hide resolved
core/servicedata/service.go Outdated Show resolved Hide resolved
@FemiNoviaLina FemiNoviaLina marked this pull request as ready for review May 16, 2024 03:59
@FemiNoviaLina FemiNoviaLina force-pushed the service-data-key-creation branch from ed9cb8c to 9471f16 Compare May 16, 2024 04:23
@FemiNoviaLina FemiNoviaLina requested a review from mabdh May 16, 2024 07:17
@FemiNoviaLina FemiNoviaLina requested a review from mabdh May 17, 2024 09:08
core/servicedata/service.go Outdated Show resolved Hide resolved
@mabdh
Copy link
Member

mabdh commented May 17, 2024

@FemiNoviaLina some lint errors there, can you please run go mod tidy first?

@FemiNoviaLina FemiNoviaLina force-pushed the service-data-key-creation branch 2 times, most recently from 3099563 to 004ad16 Compare May 17, 2024 09:54
@FemiNoviaLina FemiNoviaLina requested a review from mabdh May 17, 2024 10:00
@FemiNoviaLina FemiNoviaLina force-pushed the service-data-key-creation branch from 004ad16 to 95c3303 Compare May 17, 2024 10:08
@FemiNoviaLina FemiNoviaLina merged commit 5ca455c into main May 20, 2024
6 checks passed
mabdh added a commit that referenced this pull request May 20, 2024
mabdh added a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants