Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fetch user email error log #48

Merged
merged 5 commits into from
May 17, 2024
Merged

fix: fetch user email error log #48

merged 5 commits into from
May 17, 2024

Conversation

FemiNoviaLina
Copy link

add email detail to fetch user email error log.

@FemiNoviaLina FemiNoviaLina force-pushed the add-email-detail-log branch from 2d9f37f to 67c66e3 Compare May 16, 2024 07:00
@FemiNoviaLina FemiNoviaLina marked this pull request as ready for review May 16, 2024 07:04
@FemiNoviaLina FemiNoviaLina requested a review from mabdh May 16, 2024 07:04
mabdh
mabdh reviewed May 16, 2024
View reviewed changes
core/action/service.go Outdated Show resolved Hide resolved
@FemiNoviaLina FemiNoviaLina requested a review from mabdh May 16, 2024 07:47
@FemiNoviaLina
Copy link
Author

decided to only replace ErrNotExist and not replace ErrMissingEmail , also added block to catch it instead so the log can be clearer for each case. please let me know it its better to just using ErrInvalidEmail for missing email in header. @mabdh

Screenshot 2024-05-17 at 16 02 22

@FemiNoviaLina FemiNoviaLina merged commit cf4b97f into main May 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabdh mabdh mabdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FemiNoviaLina @mabdh