feat: servicedata #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishanarya0
changed the title
ishanarya0
changed the title
mabdh
previously approved these changes
Jun 13, 2024
* feat: update user API to use servicedata * feat: update group metadata using servicedata service * refactor: user servicedata service to serve metadata (#82) * feat: use servicedata service to serve metadata * feat: change value to jsonb * refactor * fix: e2e-test, user, group and servicedat tests * test: fix * test: fix * test: fix * lint: fix
ishanarya0
changed the title
mabdh
reviewed
Jun 18, 2024
|
todo - add default project creation logic |
* feat: make servicedata key public * fix: schema generator test * test: spicedb image tab * test: fix image repo * test: fix image version * test: fix command * test: remove command flag * test: add e2e-tests * refactor: wildcard role check
manishdangi98
previously approved these changes
Jul 18, 2024
manishdangi98
dismissed
their stale review
Coverage decreased need to add more test cases
mabdh
approved these changes
Jul 18, 2024
FemiNoviaLina
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service data service to be used to serve metadata