refactor: user servicedata service to serve metadata #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishanarya0
changed the base branch from
main
to
servicedata-for-metadata-update-apis
mabdh
reviewed
Jun 15, 2024
mabdh
reviewed
Jun 15, 2024
mabdh
reviewed
Jun 15, 2024
mabdh
reviewed
Jun 15, 2024
mabdh
reviewed
Jun 15, 2024
mabdh
reviewed
Jun 15, 2024
mabdh
reviewed
Jun 15, 2024
mabdh
reviewed
Jun 15, 2024
| NamespaceID string `db:"namespace_id"` | ||
| EntityID string `db:"entity_id"` | ||
| Value sql.NullString `db:"value"` | ||
| Key string `db:"key"` |
There was a problem hiding this comment.
Probably we could be more specific on this one, whether this is KeyURN or KeyID or KeyName
mabdh
reviewed
Jun 15, 2024
mabdh
reviewed
Jun 17, 2024
mabdh
reviewed
Jun 17, 2024
mabdh
reviewed
Jun 17, 2024
ishanarya0
merged commit 9778e5c
into
servicedata-for-metadata-update-apis
3 of 4 checks passed
ishanarya0
added a commit
that referenced
this pull request
Jun 18, 2024
* feat: update user API to use servicedata * feat: update group metadata using servicedata service * refactor: user servicedata service to serve metadata (#82) * feat: use servicedata service to serve metadata * feat: change value to jsonb * refactor * fix: e2e-test, user, group and servicedat tests * test: fix * test: fix * test: fix * lint: fix
ishanarya0
added a commit
that referenced
this pull request
Jul 18, 2024
* feat: user service data to serve metadata * fix: should not return error if user email is missing * chore: remove unwanted imports * feat: get group metadata from servicedata * feat: update APIs to use servicedata (#74) * feat: update user API to use servicedata * feat: update group metadata using servicedata service * refactor: user servicedata service to serve metadata (#82) * feat: use servicedata service to serve metadata * feat: change value to jsonb * refactor * fix: e2e-test, user, group and servicedat tests * test: fix * test: fix * test: fix * lint: fix * fix: field name * lint: format * fix: check permission on keys before create/update * lint: formatting * fix: check permission on keys before create/update * refactor: change field name * fix: add consistency to lookup resource * feat: make servicedata key public (#86) * feat: make servicedata key public * fix: schema generator test * test: spicedb image tab * test: fix image repo * test: fix image version * test: fix command * test: remove command flag * test: add e2e-tests * refactor: wildcard role check * test: fix * test: fix * test: fix * test: fix wrong response * fix: self API * test * test * test: update create group test * test: update update group test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user servicedata service to serve metadata