Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove: deprecating binary plugin #22

Closed
wants to merge 2 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
remove: github action related to binary plugin test
deryrahman committed Nov 1, 2023
commit 884bd1ece9662d7eb14bf9b3f0b868780e4e6f8c
13 changes: 0 additions & 13 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -8,19 +8,6 @@ on:
workflow_dispatch:

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to remove some parts in goreleaser file as well, like builds: section (need to check other as well though)

jobs:
binary_bq2bq:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
with:
fetch-depth: 0
- name: Set up Golang
uses: actions/setup-go@v4
with:
go-version: '1.20'
- name: test binary bq2bq
run: make test
executor_bq2bq:
runs-on: ubuntu-latest
steps:
17 changes: 0 additions & 17 deletions Makefile
Original file line number Diff line number Diff line change
@@ -20,22 +20,5 @@ install: ## install plugin to optimus directory
clean: ## clean binaries
rm -rf ./dist

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need to check install, like maybe we don't need the line with:

cp cp ./dist/bq2bq_darwin_amd64/* ~/.optimus/plugins/

fmt: ## Run FMT
@for target in ${TASKS}; do \
cd ${ROOT}/task/$${target}; go fmt . ; go mod tidy; \
done
@for target in ${HOOKS}; do \
cd ${ROOT}/hook/$${target}; go fmt . ; go mod tidy; \
done

test: ## Run tests
@for target in ${TASKS}; do \
cd ${ROOT}/task/$${target}; go vet . ; go test . -race; \
cd ${ROOT}/task/$${target}; go vet . ; go test ./upstream --cover -race; \
done
@for target in ${HOOKS}; do \
cd ${ROOT}/hook/$${target}; go vet . ; go test . -race; \
done

help:
@grep -E '^[a-zA-Z0-9_-]+:.*?## .*$$' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}'