Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty resource #23

Merged
merged 8 commits into from
Oct 30, 2023
Merged

fix: empty resource #23

merged 8 commits into from
Oct 30, 2023

Conversation

irainia
Copy link

@irainia irainia commented Oct 27, 2023

No description provided.

@irainia irainia requested a review from arinda-arif October 27, 2023 09:19
@irainia irainia merged commit fe52f52 into main Oct 30, 2023
2 checks passed
@irainia irainia deleted the fix-empty-resource branch October 30, 2023 07:43
irainia added a commit that referenced this pull request Oct 30, 2023
* refactor: update naming within upstream for more readability

* fix: remove upstream implementation to resource only

* refactor: extract out group upstream extraction

* test: add sorting actual results to ensure consistency

* fix: ignore error caused by access denied or user permission issue

* refactor: remove unnecessary implementation in test

* refactor: move out ignorable error handling to extractor

* fix: update to add logger to extractor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants