feat: add instrumentation opentelemetry #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deryrahman
changed the title
deryrahman
force-pushed
the
add-instrumentation
branch
from
eb93e26 to
13df94b
Compare
deryrahman
force-pushed
the
add-instrumentation
branch
from
13df94b to
c0e8fbb
Compare
sbchaos
reviewed
Sep 30, 2024
max2max/internal/loader/append.go
Outdated
Comment on lines
35
to
38
| l.queryCounter.Add(context.Background(), 1, metric.WithAttributes( | ||
| attribute.String("method", "GetQuery"), | ||
| attribute.String("tableID", tableID), | ||
| )) |
There was a problem hiding this comment.
Do we need a telemetry for this function ? I does not include any external calls.
There was a problem hiding this comment.
this is just a sample for sending telemetry metrics to collector, I'll remove it as it's not necessary
sbchaos
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.