Remove restriction in custom_res against top-level directory #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, custom_res rule enforces that dir_name is not in the same
directory as the package. It does this implicitly:
```
old_resource_path.replace("/" + dir_name, "/res")
```
This means that if `"/" + dir_name` does not exist in the resource path,
nothing will be replaced, and the rule fails. Meaning that, for instance:
```
.
├── BUILD.bazel
├── res
├── res-debug
└── res-release
```
This fails, because the resource path is `res-debug/values/example.xml`.
By the nature of the rule, the dir_name ending in a slash feels more correct
to enforce than starting with a slash.
arunkumar9t2
approved these changes
Jun 18, 2024
|
Thanks! |
arunkumar9t2
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, custom_res rule enforces that dir_name is not in the same directory as the package. It does this implicitly:
This means that if
"/" + dir_namedoes not exist in the resource path, nothing will be replaced, and the rule fails. Meaning that, for instance:This fails, because the resource path is
res-debug/values/example.xml.By the nature of the rule, the resource paths having dir_name plus a slash at the end feels more correct to enforce than starting with a slash.