Deprecate space assignment syntax for Groovy #31424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bot-gradle test this |
This comment has been minimized.
This comment has been minimized.
|
The following builds have failed: |
ov7a
force-pushed
the
ov7a/deprecate-space-assignment
branch
4 times, most recently
from
033b613 to
3482f89
Compare
ov7a
requested review from
octylFractal,
hegyibalint,
bamboo and
alllex
and removed request for
a team
ov7a
force-pushed
the
ov7a/deprecate-space-assignment
branch
from
3482f89 to
f794530
Compare
mlopatkin
requested review from
mlopatkin
and removed request for
alllex and
a team
mlopatkin
requested changes
Dec 3, 2024
There was a problem hiding this comment.
Great work! Thank you for fixing buildDir uses along the way.
I must say, it would be significantly easier to review the PR if purely mechanical changes of adding = without changing anything else were in a separate PR. The PR this big gave hard time to my browser.
❓ It looks like AGP has plenty of snippets that rely on the space-assignment syntax, for example, here. We might want to reach out to them.
There are some stylistic issues in public docs, that, I think, are worth addressing before merging. I'm less concerned about tests, though inconsistent use of uri(..) and file(..) gives me an itch. But the time to fix that is better spent elsewhere.
...-core/src/main/java/org/gradle/internal/instantiation/generator/AsmBackedClassGenerator.java
Outdated
Show resolved
Hide resolved
platforms/documentation/docs/src/docs/userguide/releases/upgrading/upgrading_version_8.adoc
Outdated
Show resolved
Hide resolved
platforms/documentation/docs/src/docs/userguide/releases/upgrading/upgrading_version_8.adoc
Outdated
Show resolved
Hide resolved
platforms/documentation/docs/src/docs/userguide/releases/upgrading/upgrading_version_8.adoc
Show resolved
Hide resolved
...-core/src/main/java/org/gradle/internal/instantiation/generator/AsmBackedClassGenerator.java
Outdated
Show resolved
Hide resolved
...egTest/groovy/org/gradle/api/publish/maven/MavenPublishArtifactCustomizationIntegTest.groovy
Outdated
Show resolved
Hide resolved
...n/src/integTest/groovy/org/gradle/api/publish/maven/MavenPublishPomPackagingIntegTest.groovy
Outdated
Show resolved
Hide resolved
...are/maven/src/test/groovy/org/gradle/api/publish/maven/plugins/MavenPublishPluginTest.groovy
Outdated
Show resolved
Hide resolved
testing/smoke-test/src/smokeTest/groovy/org/gradle/smoketests/NebulaPluginsSmokeTest.groovy
Outdated
Show resolved
Hide resolved
...e-test/src/smokeTest/resources/org/gradle/smoketests/android-kotlin-example/app/build.gradle
Outdated
Show resolved
Hide resolved
mlopatkin
approved these changes
Dec 3, 2024
| @@ -8,20 +8,20 @@ repositories { | |||
| } | |||
|
|
|||
| android { | |||
| compileSdkVersion 30 | |||
| compileSdkVersion = 30 | |||
There was a problem hiding this comment.
Suggested change
| compileSdkVersion = 30 | |
| compileSdk = 30 |
ov7a
force-pushed
the
ov7a/deprecate-space-assignment
branch
from
d7d0ef2 to
a5999d2
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…d use layout where possible
ov7a
force-pushed
the
ov7a/deprecate-space-assignment
branch
from
a5999d2 to
2320428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #31413
Note: the relevant commit is
The suppression for smoke-tested plugins is in
(SantaTracker, Build Scans, Nebula Plugin)
The last two commits are docs and tests changes.
Reviewing cheatsheet
Before merging the PR, comments starting with