Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to bypass the serialisation and directly make the REST call to druid API. #85

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

saketbairoliya2
Copy link
Contributor

Have added a PR to address this issue: grafadruid/druid-grafana#155.

@saketbairoliya2
Copy link
Contributor Author

Please let me know if we've a format to follow to raise a PR. @jbguerraz

@cosmic-chichu
Copy link
Contributor

cosmic-chichu commented Jul 7, 2023

I like that we have now have an option to execute raw(bytes) requests while we add features for parity with Druid.

Disregard this comment.

@cosmic-chichu
Copy link
Contributor

cosmic-chichu commented Jul 9, 2023

This is already available as long as you are using a raw Druid native query not created using this library.

Example:
client, _ := druid.NewClient(baseURL, options...)
var results interface{}
druidResponse, _ := client.ExecuteRequest(http.MethodPost, "druid/v2", json.RawMessage(rawQuery), &results)

We should add this to the examples

@saketbairoliya2
Copy link
Contributor Author

Sounds good @cosmic-chichu - Will add the example.

@saketbairoliya2
Copy link
Contributor Author

@cosmic-chichu - Any idea with the usage of above function what all changes we'll need to make here to call above function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants