-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard Builder: Add capability to use Grafonnet #13
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering about the security of calling a command line without checking its content ?
Should it increase user privileges ? if the command (grafana-import) has sudo rights it may cause pb !
It is especially for .py files (not jsonnet !)
Maybe a warning on this case should be set in the README...
It is a marginal case but...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. I hear you on one hand, but on the other, giving a regular program like grafana-import which can do all sorts of things root permissions would be a bad idea per se, no?
If a user can run a (dashboard builder) program with
python dashboard-builder.py
, or if they do it through grafana-import, does not make any big difference, right?It might be different when grafana-import would expose its functionality via a web service or similar means, where the user and the runtime are on different machines. But still in this case, I guess
shlex.split()
offers enough protective measures so it can't be exploited to invoke a different program, if you are referring to that?So, if you don't mind, my personal evaluation of this is that shelling out like grafana-import is doing it, is safe enough for its purpose. If you really think it's not, or if anyone else from the community has any other objections or concerns, please let me know on behalf of a concrete example that demonstrates a relevant vulnerability, by creating a dedicated issue.
If you think I misunderstood your statement, where I translated "sudo rights" into "root permissions", please let me know. What does "pb" actually refer to?