Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix folder issue #22

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Fix folder issue #22

merged 3 commits into from
Oct 10, 2024

Conversation

vrymar
Copy link
Contributor

@vrymar vrymar commented Oct 7, 2024

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@fbf4026). Learn more about missing BASE report.

Files with missing lines Patch % Lines
grafana_import/util.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage        ?   69.33%           
=======================================
  Files           ?        5           
  Lines           ?      424           
  Branches        ?        0           
=======================================
  Hits            ?      294           
  Misses          ?      130           
  Partials        ?        0           
Flag Coverage Δ
unittests 69.33% <83.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! I've slightly amended your patch to make it pass CI, and hope it is semantically still correct.

@amotl amotl merged commit aeece73 into grafana-toolbox:main Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants