Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update usage example to reflect new repo layout #12

Merged
merged 5 commits into from
Apr 22, 2024
Merged

docs: update usage example to reflect new repo layout #12

merged 5 commits into from
Apr 22, 2024

Conversation

hbjydev
Copy link
Contributor

@hbjydev hbjydev commented Apr 11, 2024 •
edited
Loading

Changes

  • Updates references to old flow-modules repo
  • Updates file path for path argument to module.git
  • Updates stack argument to stack_name
  • Updates syntax to match how Alloy works instead of Flow mode
  • Adds warning about the module requiring --stability.level=public-preview to use the module due to pyroscope.* being public-preview stability.

erikbaranowski
erikbaranowski requested changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@erikbaranowski erikbaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the assist on this module. Some small things to address before merge.

modules/cloud/grafana/cloud/README.md Outdated Show resolved Hide resolved
modules/cloud/grafana/cloud/README.md Outdated Show resolved Hide resolved
modules/cloud/grafana/cloud/README.md Show resolved Hide resolved
@hbjydev
docs: resolve change requests in MR
dec2ae5 
- It _is_ `import.git`, not `module.git`, my bad.
- The path is `module.alloy`, not `module.river`.
@hbjydev
Copy link
Contributor Author

hbjydev commented Apr 12, 2024

No worries @erikbaranowski -- I've dealt with your change requests :)

@qclaogui qclaogui mentioned this pull request Apr 17, 2024
Open
@erikbaranowski erikbaranowski merged commit 3588a6e into grafana:main Apr 22, 2024
13 checks passed
@hbjydev hbjydev deleted the patch-1 branch April 23, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikbaranowski erikbaranowski erikbaranowski approved these changes

@mattdurham mattdurham Awaiting requested review from mattdurham mattdurham is a code owner

@bentonam bentonam Awaiting requested review from bentonam bentonam is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbjydev @erikbaranowski