Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: kubernetes/annotations/metrics.alloy won't load because the
kubernetes
discovery/relabel component referencesscrape_timeout
andscrape_interval
, which are not declared.I think this is the intended solution to this. The
scrape_timeout
andscrape_interval
should be set in thekubernetes
section so that they are able to be replaced if a service sets the label to override. Thescrape_timeout
andscrape_interval
should be removed from theprometheus.scrape
components of themetrics
section, so that both values can be set by the__scrape_timeout__
and__scrape_interval__
labels respectively, which should be set during discovery/relabel to either the default, the passed argument, or the overriding kube label.Notated the same in the readme as well as fixed some incorrect references. I did verify this change in a running cluster by both setting an argument as well as setting a service label.