change all metrics.alloy to drop init container in separate step #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamhackl
requested review from
erikbaranowski,
mattdurham and
bentonam
as code owners
adamhackl
force-pushed
the
init-container-drops
branch
from
1642dac
to
f72e96b
Compare
adamhackl
force-pushed
the
init-container-drops
branch
from
4af2ac9
to
eb1789d
Compare
petewall
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have had issues where a container is inadvertently dropped because it does not have the label
__meta_kubernetes_pod_container_initat all. The keep step is looking for the label to be present and set tofalse. Instead, I moved this check out to its own rule to drop if the label is set totrue. This clears up the false drops, but still keeps the intention of the original step to not scrape init pods.I originally had this issue with the
kube_dnsrelabel inkubernetes/core/metrics.alloyand was able to resolve and test this fix. I went through and updated anymetrics.alloythat had this pattern with the assumption that it should also be fixed in those as well.