HTTP Server: Fix CSV deletion (#530)

grafana · Jun 11, 2024 · 4f04533 · 4f04533
1 parent d3165a1
commit 4f04533
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/src/service/http-server.ts b/src/service/http-server.ts
@@ -296,12 +296,17 @@ export class HttpServer {
       } else {
         try {
           this.log.debug('Deleting temporary file', 'file', result.filePath);
-          fs.unlinkSync(result.filePath);
-          if (!options.filePath) {
-            fs.rmdirSync(path.dirname(result.filePath));
-          }
+          fs.unlink(result.filePath, (err) => {
+            if (err) {
+              throw err
+            }
+
+            if (!options.filePath) {
+              fs.rmdir(path.dirname(result.filePath), () => {});
+            }
+          })
         } catch (e) {
-          this.log.error('Failed to delete temporary file', 'file', result.filePath);
+          this.log.error('Failed to delete temporary file', 'file', result.filePath, 'error', e.message);
         }
       }
     });