Implement spec.uid
for GrafanaContactPoint
#1730
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing this, I noticed a lot of discrepancies between the
ContactPoint
CR and the others.Once this is merged I'll open a PR fixing the missing error logs when ContactPoints fail to reconcile as well as implementing the same Status fields that other CRs use. (See: 7e81cb4)
Manual Testing
tmp.yml