chore(internal): switch all resources to a struct with common fields #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baarsgaard
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess and
pb82
as code owners
theSuess
approved these changes
Nov 22, 2024
weisdd
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
The changes look good, and they're much easier to review now compared to what we had in the initial huge PR :)
What I would probably consider doing it future is moving from AllowCrossNamespaceImport *bool to AllowCrossNamespaceImport bool, because, in the end, we treat false and nil equally, so we can get rid of pointer verifications. But it doesn't have to be done under this PR, we'll change it later.
weisdd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the first step towards refactoring the reconciliation loops for all CRs.
I've added a GrafanaCommonOptions struct which embeds the Common Options fields as a singular struct.
This means that all CRs will use the same comments, rules for CRD generation/deserialization, and default values.
This is especially apparent for
ResyncPeriodwhich had a few different implementations.This does add the
AllowCrossNamespaceImporttoGrafanaNotificationPolicies, but it is not handled in the Reconciliation loop as of now.It is recommended to review this one commit at a time.
Individual commits may not compile except for the final one.