Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a base_job_name tag to encompass all instances of a given job #482

Closed
wants to merge 2 commits into from

Conversation

chrissnell
Copy link

When outputting Prometheus metrics, k6-operator includes a job_name tag, but the value of this tag corresponds to the individual instance (== Pod) running a test. So, for a job called test, the values of job_name look like test-1, test-2, etc.

This makes it very difficult to build a dashboard that displays all jobs running a particular test. We need a tag that provides the name of the job without any instance numbers.

This PR adds a base_job_name tag that contains only the job name.

In the example above, this PR adds a base_job_name tag with a value of test.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Chris Snell seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@chrissnell
Copy link
Author

People want test-wide tags:

https://community.grafana.com/t/k6-operator-pass-local-environment-variable-as-test-wide-tag/99639

People are struggling with bugs:

#162
#211

@chrissnell chrissnell closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants