Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: remove permissions from the call to helm-charts #485

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

yorugac
Copy link
Collaborator

@yorugac yorugac commented Nov 1, 2024

Release workflow gets the startup failure:

Invalid workflow file: .github/workflows/helm-release.yaml#L47
The workflow is not valid. .github/workflows/helm-release.yaml (Line: 47, Col: 3): Error calling workflow 'grafana/helm-charts/.github/workflows/update-helm-repo.yaml@main'. The nested job 'release' is requesting 'packages: write', but is only allowed 'packages: none'.

Failed build: https://github.com/grafana/k6-operator/actions/runs/11628556424

Permissions are being set in the helm-charts workflow:
https://github.com/grafana/helm-charts/blob/main/.github/workflows/update-helm-repo.yaml#L96

Not certain if there could there be a conflict between the two, but it doesn't make sense to set them from the calling workflow.

@yorugac yorugac added this to the 0.18 milestone Nov 1, 2024
@yorugac yorugac merged commit 402426e into main Nov 1, 2024
13 checks passed
@yorugac yorugac deleted the ci/fix-helm-release branch November 1, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant