Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add s3 event bucketowner #14935

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add s3 event bucketowner #14935

wants to merge 1 commit into from

Conversation

maxHyeon
Copy link

fix: s3 event label typo

What this PR does / why we need it:
If you have set the ownership security of the S3 Bucket in the S3 log function through the Event bridge of Tool Lambda Promtail, there is a bug in which InvalidBucketOwnerAWSAccountID occurs because there is no Bucket Owenr.

Through this PR, I have added the Bucket Owner Account ID as an S3 event in the event parsed from Lambda Promtail's Eventbridge and corrected a typo in the Bucket Owner label in the S3 Event so that logs can be collected normally even in situations where BucketOwnership authentication is present. It has been supplemented.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • [O ] Reviewed the CONTRIBUTING.md guide (required)
  • [ O] Documentation added
  • [ O] Tests updated
  • [ O] Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • [O ] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • [ O] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

fix: s3 event label typo
@maxHyeon maxHyeon requested a review from a team as a code owner November 15, 2024 07:07
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants