Derive mimir image from chart when metrics enabled and fallback to up… #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dated mimir image
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dated mimir image
I ran into an issue when trying to spawn a new cluster using this chart where some conifguration values in the configmap for /etc/mimir/mimir.yaml were not recognized for the mimir-for-ruler-dashboards deployment. After some digging, it appears that the version of mimir that the 5.3.0 version of the mimir chart that this chart uses is 2.12.0 but the mimir-ruler-for-dashboards deployment in this chart was using 2.8.0 and there was a config compatibility issue.
I updated the default image version for mimir to 2.12.0 to match and also added logic to pull in the imageReference from the mimir-distributed chart when possible so that it can remain in sync.
Please let me know if there's anything you need changed. If you're not accepting PRs at this time I can also close this one down.