Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonnet: rename autoscaling_distributor_[min|max]_replicas to autoscaling_distributor_[min|max]_replicas_per_zone #10019

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pracucci
Copy link
Collaborator

What this PR does

Similarly to #8874, in this PR I propose to rename autoscaling_distributor_[min|max]_replicas to autoscaling_distributor_[min|max]_replicas_per_zone to clarify that it's a per-zone setting when distributor is deployed multi-zone.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

…ling_distributor_[min|max]_replicas_per_zone

Signed-off-by: Marco Pracucci <[email protected]>
@pracucci pracucci requested a review from a team as a code owner November 25, 2024 13:16
Copy link
Contributor

@narqo narqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants