-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tls insecure skip to analyze #9628
base: main
Are you sure you want to change the base?
Add tls insecure skip to analyze #9628
Conversation
…p into Add_tls_insecure-skip_analyze
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good to me. I've left a tiny ask to clean up the diff a bit.
Could you also add a changelog entry to the Mimirtool
section, thank you.
rulerAnalyzeCmd.Flag("auth-token", "Authentication token bearer authentication; alternatively, set "+envVars.AuthToken+"."). | ||
Default(""). | ||
Envar(envVars.AuthToken). | ||
StringVar(&raCmd.ClientConfig.AuthToken) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✂️
Can we keep this blank between different command definitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the new flag also be mentioned in a changelog entry please?
What this PR does
What this PR does
Add -tls-insecure-skip-verify to analyze.
Currently, only the rules support using the -tls-insecure-skip-verify flag or the correspondent env var.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.