MQE: Add support for histogram_quantile #9929
Open
+2,187
−663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhesketh
requested review from
stevesg,
grafanabot and
a team
as code owners
Also preps support for more classic histogram functions to come. (Will require some re-work, but the basics are there). Tidies up annotation tests and checks their results between engines. (Since sometimes we emit annotations with results, and sometimes the results are omitted when there is an annotation).
jhesketh
force-pushed
the
jhesketh/mqe-histogram-quantile
branch
from
38d1a77
to
d293f3a
Compare
jhesketh
force-pushed
the
jhesketh/mqe-histogram-quantile
branch
from
d89bbab
to
78fc811
Compare
jhesketh
force-pushed
the
jhesketh/mqe-histogram-quantile
branch
from
78fc811
to
5abeee0
Compare
charleskorn
reviewed
Nov 18, 2024
jhesketh
force-pushed
the
jhesketh/mqe-histogram-quantile
branch
from
c20de2b
to
016d546
Compare
charleskorn
reviewed
Nov 18, 2024
charleskorn
reviewed
Nov 22, 2024
There was a problem hiding this comment.
This is looking good.
I'd like to see some benchmark results, and I'd also like for
histogram_quantile to go behind a feature flag so we can turn it off if need be - there's a lot of complexity here, and while I can't see any obvious issues, it'd be good to have that available if we need it.
charleskorn
reviewed
Nov 26, 2024
|
Benchmarks: The results are obviously concerning. I have not had time to investigate why yet. |
|
An improvement with more pools: Still doesn't scale well because of how we load series time-wise. I'm not sure if we can do much more without fundamental changes :-/ |
charleskorn
reviewed
Nov 27, 2024
|
The thing that stands out to me in the benchmarks is not the peak memory consumption, which looks good, but the number of allocations. Where are all of the allocations happening in the 1000 step cases? |
It's related to the bucketSliceBucketedPool
|
I suspect that |
|
Latest benchmark, fixing the heap-allocation of defers. |
charleskorn
reviewed
Nov 27, 2024
|
Latest benchmarks, including native histograms: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidies up annotation tests and checks their results between engines. (Since sometimes we emit annotations with results, and sometimes the results are omitted when there is an annotation).
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.