fix: pass redis SSL config to connection pool #5220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This fix will pass SSL config properly to redis connection pool.
django-redis passes
CONNECTION_POOL_KWARGS
and notCONNECTION_POOL_CLASS_KWARGS
to connection pool class, related django-redis code can be seen here.Also, without this fix other settings
max_connections
andtimeout
are also not passed to connection pool.I had issues with external Redis with in-transit encryption enabled using self-signed certs (Google managed Redis).
After changing this I can properly pass self-signed CA cert to redis client using
REDIS_SSL_CA_CERTS
env variable.Which issue(s) this PR closes
There is no issue created for this problem.
Checklist
pr:no public docs
PR label added if not required)release:
). These labels dictate how your PR willshow up in the autogenerated release notes.