Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge alert group static labels to integration labels #5262

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

Merge alert group static labels to integration labels #5262

wants to merge 11 commits into from

Conversation

Ferril
Copy link
Member

@Ferril Ferril commented Nov 18, 2024 •
edited
Loading

What this PR does

Adds migration to merge static labels to integration labels. On creating new static label in UI saves it as integration label.
This PR should be merged together with frontend changes.

Which issue(s) this PR closes

Related to https://github.com/grafana/oncall-private/issues/2973

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@Ferril Ferril requested a review from a team as a code owner November 18, 2024 10:43
@Ferril Ferril changed the title Merge static labels to integration labels Merge alert group static labels to integration labels Nov 18, 2024
@Konstantinov-Innokentii
Copy link
Member

@Ferril Thanks! Frontend changes are going to live in this PR as well, right?

@Ferril Ferril requested review from a team as code owners November 18, 2024 10:50
@Ferril Ferril added the release:patch PR will be added to "Other Changes" section of release notes label Nov 18, 2024
@Ferril
Copy link
Member Author

Ferril commented Nov 18, 2024

@Ferril Thanks! Frontend changes are going to live in this PR as well, right?

Not sure how it works now. Better to ask @brojd 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:patch PR will be added to "Other Changes" section of release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ferril @Konstantinov-Innokentii