-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add/update resource handler topics for datasource and app plugins #1081
Conversation
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content LGTM!
docusaurus/docs/how-to-guides/data-source-plugins/add-resource-handler.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/how-to-guides/app-plugins/add-resource-handler.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/how-to-guides/app-plugins/add-resource-handler.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/how-to-guides/app-plugins/add-resource-handler.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should attempt to make the content about CallResourceHandler generic (no mention of app or data source), put it in a shared file and import it in both guides. Then in data sources you can put the specific frontend code and in app the specific frontend app code.
docusaurus/docs/how-to-guides/app-plugins/add-resource-handler.md
Outdated
Show resolved
Hide resolved
@academo @andresmgot I think I've managed to do what you suggested. PTAL 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I only have a couple minor suggestions
docusaurus/docs/how-to-guides/app-plugins/add-resource-handler.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/how-to-guides/app-plugins/add-resource-handler.md
Outdated
Show resolved
Hide resolved
|
||
## Uses of resource handlers | ||
|
||
The use case and functionality for an app is very broad and therefore also for uses of resource handlers. But in general, an app normally integrates with a HTTP service of some kind, e.g. a 3rd party service, to retrieve and send data. For example, this service might have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use case and functionality for an app is very broad and therefore also for uses of resource handlers.
This sentence confused me a bit, could you rephrase it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL
Closes #878
Closes #1032