fix: allow slashes in application name #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcsanmi
force-pushed
the
marcsanmi/allow-slashes-app-name
branch
from
7e1216c
to
7d0a678
Compare
kolesnikovae
approved these changes
Nov 28, 2024
| @@ -101,7 +101,7 @@ func IsTagKeyRuneAllowed(r rune) bool { | |||
| } | |||
|
|
|||
| func IsAppNameRuneAllowed(r rune) bool { | |||
| return r == '-' || r == '.' || IsTagKeyRuneAllowed(r) | |||
| return r == '-' || r == '.' || r == '/' || IsTagKeyRuneAllowed(r) | |||
There was a problem hiding this comment.
Ideally, we want to get rid of the internal/flameql and unify the way we handle labels. I propose to explore a way where we use the exact same parsing and validation as in the Push API and treat labels as Prometheus ones.
There was a problem hiding this comment.
That makes sense. I'll create an issue to explore this further. I had to replicate this change in three places (Pyroscope, Alloy, and here), so it's definitely not the ideal approach 😅
There was a problem hiding this comment.
Oh, I had already created it when I needed to duplicate the logic in Alloy https://github.com/grafana/pyroscope-squad/issues/257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See grafana/pyroscope#3722.
Also added missing tests.