@datadog/pprof integration #39
Conversation
This reverts commit c9c017f.
…to feat/cpu-profiler-tags
|
|
| import type perftools from 'pprof/proto/profile' | ||
| import debug from 'debug' | ||
| import axios, { AxiosBasicCredentials, AxiosError } from 'axios' | ||
| import FormData from 'form-data' | ||
| import 'regenerator-runtime/runtime' |
There was a problem hiding this comment.
Why do we import this? Users of this library should decide whether or not they want to import this runtime, but users that do not rely on this runtime won't be interested in importing it
jest.config.js
Outdated
| "./cpu.js": "<rootDir>/src/cpu.ts", | ||
| "./wall.js": "<rootDir>/src/wall.ts", | ||
| "./heap.js": "<rootDir>/src/heap.ts", |
There was a problem hiding this comment.
This belongs to the old PR and should be removed
| @@ -29,7 +29,7 @@ Pyroscope supports two main operation modes: | |||
|
|
|||
| Push mode means the package itself uploads profile data to a pyroscope server, when pull mode means you provide pyroscope server with an endponts to scrape profile data | |||
|
|
|||
| NodeJS Pyroscope module supports collecting wall-time and heap. More details you may find [here](https://cloud.google.com/profiler/docs/concepts-profiling) | |||
There was a problem hiding this comment.
Docs must be updated
| @@ -0,0 +1,21 @@ | |||
| export interface PyroscopeConfig { | |||
There was a problem hiding this comment.
To do: add source map support
| }) | ||
| }) | ||
| it('should respond to repetitive cpu calls', async () => { | ||
| const app = express() |
There was a problem hiding this comment.
@korniltsev we need to think about this case. What should we do on consecutive calls? How do we handle the profiler? The old implementation closed the profiler so it could not handle consecutive cpu calls
|
cc @grafakus , @Rperry2174 |
|
@notaphplover |
|
Hey @notaphplover / @korniltsev — I finished this branch and merged it today. I had to use the old PR though instead of this one because I could not push to this PR — sorry about the confusion. And thanks for the contributions! |
|
🎉🎉🎉 |
This is, for now, a work in progress that aims to update the library in such a way it uses the
@datadog/pproflibrary for profiling purposes.An overview of the changes is the folowing one:
PyroscopeConfighas been updated with equivalent options.PyroscopeProfilerhas been added internally to encapsulate different API operations.fromanduntilparameters to the ingest endpoint.