Add dynamic labels to the wall profiler #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
force-pushed
the
20240522_use-tag-wrapper-for-wall
branch
from
8000fed to
335d3f4
Compare
simonswine
changed the title
simonswine
force-pushed
the
20240522_use-tag-wrapper-for-wall
branch
from
335d3f4 to
c44b155
Compare
This adds dyanmic labels for wall profiling.
simonswine
force-pushed
the
20240522_use-tag-wrapper-for-wall
branch
from
c44b155 to
ee134da
Compare
bryanhuhta
approved these changes
May 28, 2024
| ...oldLabels, | ||
| ...lbls, | ||
| }) | ||
| ;(fn as AnyWrappedCallback)(...args) |
There was a problem hiding this comment.
Is this semicolon necessary?
Suggested change
| ;(fn as AnyWrappedCallback)(...args) | |
| (fn as AnyWrappedCallback)(...args) |
There was a problem hiding this comment.
I think so, don't ask me why though
There was a problem hiding this comment.
Yes it is; it separates the statements.
If not, the JS engine tries to use the return value of setLabels as a function that will receive the fn parameter.
Adding or not semicolons at the end of each line of JS code can be debated.
But for sure, not having them can create this confusion. Maybe we should configure Prettier to format the code automatically (in a future PR).
Co-authored-by: Bryan Huhta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add dynamic labels to the wall profiler. This includes a wrapper for ensuring labels are set while a function executed.
I have also extended the test to measure how this feature works on a real profile.