Simplify Dockerfile, remove redundant Dockerfile.build.
#1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roobre
force-pushed
the
dockerfile-simplify
branch
3 times, most recently
from
49f308b
to
c155a90
Compare
roobre
force-pushed
the
dockerfile-simplify
branch
from
c155a90
to
c561f5f
Compare
|
There's nothing "redundant" about Dockerfile.build. I don't want to touch the Drone pipeline unless required. My expectation was to be able to remove the drone pipeline sooner, but that hasn't happened yet. Dockerfile is used by Drone, Dockerfile.build is used by GHA. |
mem
requested changes
Nov 18, 2024
|
@mem I'm just toying with this for the moment, changing things and see what breaks to understand better the pipeline. I have no intention to merge it as-is (that's why it's a draft) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the Dockerfile so the
browserflavor is based on the regular one, speeding up build and reducing duplication, as well as making the non-browser image the default and updating the README accordingly.On the CI side, it changes the pipeline to use that Dockerfile (instead of Dockerfile.build).