fix: delete command supports kinds that do not match singular/plural names #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…names If a resource has the kind "HiThere" but its singular is "hi-there" then deletion was not possible since Tanka operated on the kind and not the singular/plural defined in the CRD. This changes the handling to following the `TYPE.VERSION.GROUP` format when possible.
zerok
force-pushed
the
zerok/delete-with-mixed-crd-names
branch
from
b72a951
to
c6a55e0
Compare
zerok
changed the title
dsotirakis
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a resource has the kind "HiThere" but its singular is "hi-there" then deletion was not possible since Tanka operated on the kind and not the singular/plural defined in the CRD.
This changes the handling to following the
TYPE.VERSION.GROUPformat when possible.Resolves #1229