Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to display a polyline instead of circles only #260

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

srclosson
Copy link
Member

Why?

  1. Be able to use the latest version of leaflet
  2. Strava has the capability of returning a polyline, strava will decode the polyline, but can also return the polyline in the dataframe meta if the panel wants to decode. Using this format allows the map to display the activity as a line, rather than circles. The circles may be better suited for tracking individual segments of an activity (ie: how much elevation did I gain in this last segment, or how high was my heart rate).
  3. Currently, only the last activity was displayed. Changed to display all activities (or if an entry in a dataframes data section refers to an activity, use all activities defined in the dataframes data section.)

CirceCI added 2 commits April 6, 2020 10:07
Be able to visualize strava activities as polylines
OR
traditionally as circles like in a heatmap.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


CirceCI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@srclosson srclosson changed the title Src polylines Be able to display a polyline instead of circles only Apr 6, 2020
@srclosson srclosson self-assigned this Apr 6, 2020
@amotl
Copy link

amotl commented Apr 6, 2020

Dear Stephanie,

thanks for your contribution! May I humbly ask you to send this PR against [1]? This code base has been advanced to some amount and I will be happy to merge it. So, the community will gain more features on many levels.

Thanks already and with kind regards,
Andreas.

[1] https://github.com/panodata/grafana-map-panel

@srclosson
Copy link
Member Author

Yup, will do :)

@ae3e ae3e mentioned this pull request May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants