Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'asset-pipeline-gradle, grails-datastore-gorm-mongodb and views-gradle to grails-bom` #13872

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Add 'asset-pipeline-gradle, grails-datastore-gorm-mongodb and views-gradle to grails-bom` #13872

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a20b0d
fix: add `asset-pipeline-gradle` to `grails-bom`
matrei Nov 22, 2024
6308047
fix: add `grails-datastore-gorm-mongodb` to `grails-bom`
matrei Nov 22, 2024
920e70f
fix: add `views-gradle` to `grails-bom`
matrei Nov 22, 2024
a821029
Merge branch '7.0.x' into matrei/additions-to-bom
codeconsole Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dependabot/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Generated on Mon Oct 21 14:36:55 PDT 2024 by: ./gradlew :grails-bom:dependabotBuild
// Generated on Fri Nov 22 09:58:56 CET 2024 by: ./gradlew :grails-bom:dependabotBuild
plugins {
id 'java-library'
}
Expand All @@ -7,6 +7,7 @@ dependencies {
api "org.apache.ant:ant:${project['ant.version']}"
api "org.apache.ant:ant-junit:${project['ant.version']}"
api "org.asciidoctor:asciidoctorj:${project['asciidoctorj.version']}"
api "com.bertramlabs.plugins:asset-pipeline-gradle:${project['asset-pipeline-gradle.version']}"
api "com.bertramlabs.plugins:asset-pipeline-grails:${project['asset-pipeline-grails.version']}"
api "net.bytebuddy:byte-buddy:${project['byte-buddy.version']}"
api "commons-codec:commons-codec:${project['commons-codec.version']}"
Expand All @@ -24,6 +25,7 @@ dependencies {
api "org.grails:grails-events-rxjava:${project['grails-async.version']}"
api "org.grails:grails-events-rxjava2:${project['grails-async.version']}"
api "org.grails:grails-datastore-gorm-hibernate5:${project['grails-datastore-gorm-hibernate5.version']}"
api "org.grails:grails-datastore-gorm-mongodb:${project['grails-datastore-gorm-mongodb.version']}"
api "org.grails:grails-datastore-async:${project['grails-datastore.version']}"
api "org.grails:grails-datastore-core:${project['grails-datastore.version']}"
api "org.grails:grails-datastore-gorm:${project['grails-datastore.version']}"
Expand Down
4 changes: 3 additions & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,11 @@ org.gradle.parallel=true
org.gradle.daemon=true
org.gradle.jvmargs=-Dfile.encoding=UTF-8 -Xmx1536M -XX:MaxMetaspaceSize=1024M

# Generated on Tue Oct 22 16:16:30 EDT 2024 by: ./gradlew :grails-bom:syncProps
# Generated on Fri Nov 22 09:58:56 CET 2024 by: ./gradlew :grails-bom:syncProps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2 points for running the task 😉

# Only version value modifications allowed after this point. Do not insert or change version names.
ant.version=1.10.15
asciidoctorj.version=3.0.0
asset-pipeline-gradle.version=5.0.1
asset-pipeline-grails.version=5.0.1
byte-buddy.version=1.15.5
commons-codec.version=1.17.1
Expand All @@ -36,6 +37,7 @@ geb-spock.version=7.0
grails-async.version=6.0.0-SNAPSHOT
grails-datastore.version=9.0.0-SNAPSHOT
grails-datastore-gorm-hibernate5.version=9.0.0-SNAPSHOT
grails-datastore-gorm-mongodb.version=9.0.0-SNAPSHOT
grails-gdoc-engine.version=1.0.1
grails-gradle-plugin.version=7.0.0-SNAPSHOT
grails-testing-support.version=4.0.0-SNAPSHOT
Expand Down
2 changes: 2 additions & 0 deletions grails-bom/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ ext {
// version name = versionNameOverride ?: artifactId-prefixes[0]
dependenciesOverview = """\
com.bertramlabs.plugins:asset-pipeline-grails::
com.bertramlabs.plugins:asset-pipeline-gradle::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are not using SCOTL format. Shouldn't that be com.bertramlabs.plugins:asset-pipeline:gradle,grails: ? or is there a chance the version numbers won't match? I don't think they have ever been released independently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional. They have indeed been out of sync. There is for example no 4.4.0 version of asset-pipeline-grails

mattias@mattias-z4-linux:~/test/g622app$ mcs com.bertramlabs.plugins:asset-pipeline-grails:4*
Searching for com.bertramlabs.plugins:asset-pipeline-grails:4*...
Found 7 results

  Coordinates                                           Last updated
  ===========                                           ============
  com.bertramlabs.plugins:asset-pipeline-grails:4.5.2   07 Nov 2024 at 19:38 (CET)
  com.bertramlabs.plugins:asset-pipeline-grails:4.5.1   25 Jul 2024 at 18:00 (CEST)
  com.bertramlabs.plugins:asset-pipeline-grails:4.5.0   25 Jul 2024 at 17:11 (CEST)
  com.bertramlabs.plugins:asset-pipeline-grails:4.3.0   01 May 2023 at 18:20 (CEST)
  com.bertramlabs.plugins:asset-pipeline-grails:4.2.0   11 Apr 2023 at 17:36 (CEST)
  com.bertramlabs.plugins:asset-pipeline-grails:4.1.0   03 Mar 2023 at 17:57 (CET)
  com.bertramlabs.plugins:asset-pipeline-grails:4.0.0   03 Nov 2022 at 16:29 (CET)

mattias@mattias-z4-linux:~/test/g622app$ mcs com.bertramlabs.plugins:asset-pipeline-gradle:4*
Searching for com.bertramlabs.plugins:asset-pipeline-gradle:4*...
Found 8 results

  Coordinates                                           Last updated
  ===========                                           ============
  com.bertramlabs.plugins:asset-pipeline-gradle:4.5.1   25 Jul 2024 at 18:00 (CEST)
  com.bertramlabs.plugins:asset-pipeline-gradle:4.5.0   25 Jul 2024 at 17:11 (CEST)
  com.bertramlabs.plugins:asset-pipeline-gradle:4.4.0   26 Sep 2023 at 22:24 (CEST)
  com.bertramlabs.plugins:asset-pipeline-gradle:4.3.0   01 May 2023 at 18:20 (CEST)
  com.bertramlabs.plugins:asset-pipeline-gradle:4.2.0   11 Apr 2023 at 17:36 (CEST)
  com.bertramlabs.plugins:asset-pipeline-gradle:4.1.0   03 Mar 2023 at 17:57 (CET)
  com.bertramlabs.plugins:asset-pipeline-gradle:4.0.0   03 Nov 2022 at 16:29 (CET)
  com.bertramlabs.plugins:asset-pipeline-gradle:4.5.2   07 Nov 2024 at 19:38 (CET)

com.fasterxml.jackson:jackson-bom:::jackson
com.github.javaparser:javaparser-core::
com.h2database:h2::
Expand All @@ -45,6 +46,7 @@ ext {
org.grails.plugins:gsp::
org.grails:grails-async,grails-events:gpars,rxjava,rxjava2::grails-async
org.grails:grails-datastore-gorm-hibernate5::
org.grails:grails-datastore-gorm-mongodb::
org.grails:grails-datastore:async,core,gorm,gorm-async,gorm-support,gorm-rx,gorm-test,gorm-validation,web:
org.grails:grails-gdoc-engine::
org.grails:grails-gradle-plugin::
Expand Down
1 change: 1 addition & 0 deletions grails-bom/plugins.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ neo4j=8.1.0
rxjava=1.1.1
rxjava2=2.0.0
scaffolding=6.0.0-SNAPSHOT
views-gradle=4.0.0-SNAPSHOT
views-json=4.0.0-SNAPSHOT
views-json-templates=4.0.0-SNAPSHOT
views-markup=4.0.0-SNAPSHOT
Loading